You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
KeyboardApi now has uint32_t capabilities as its first member.
KEYBOARD_CAPABILITY_RESTRICTED marks limited keyboards. is_present was dropped.
Added keyboard_has_capability.
All KeyboardApi implementations have explicit .capabilities.
Kernel display hook
struct DisplayHook with on_* callbacks and display_set_hook().
The draw hook runs before the driver call. The other hooks run after it.
Exported in symbols.c and covered by display_hook_test.cpp.
Remote access (Modules/development-module)
Display viewer with zoom and rotation
Remote keyboard and touch driver
Screenshot taking
Viewer (Buildscripts/TactilitySDK/Tools)
remote.py and _remote_viewer.py use Custom2kinter.
Summary by CodeRabbit
New Features
Added remote device viewing through the tt remote command, with live display updates, screenshots, rotation and zoom controls, and keyboard and touch input.
Remote sessions can report display and input limitations, and only one remote session can run at a time.
Improvements
Display orientation is reflected in the remote view, including software-rotated displays.
SDK startup errors now provide clearer guidance for missing UI and image dependencies.
Adds remote display sessions with display-state and rectangle streaming, virtual keyboard and touch input, and remote-session routing. Adds kernel display hooks, keyboard capability reporting, and LVGL orientation support. Adds an SDK command and viewer for remote display and input. Also updates dashboard dependency guidance and widget arguments.
Merge Risk: Low · previous review 83abc
The remote viewer can leave a typed key held down on the device when Shift changes between press and release. The dashboard may fail to start on older CustomTkinter 5.2.x installs because of the progress-bar argument. Both are narrow and have small fixes, so the change is mergeable with these follow-ups.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "Keyboard fix, remote viewer added" names two real parts of the changeset. The keyboard changes add a KeyboardApi capabilities field, KEYBOARD_CAPABILITY_RESTRICTED, and keyboard_has_capabil…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "Keyboard fix, remote viewer added" names two real parts of the changeset. The keyboard changes add a KeyboardApi capabilities field, KEYBOARD_CAPABILITY_RESTRICTED, and keyboard_has_capability, and remove is_present. The remote viewer is added through remote.py and _remote_viewer.py, along with the development-module remote access. The title does not name the largest change, which is the remote access and viewer feature, and the word "fix" is broad because the keyboard change is an API refactor rather than a clear bug fix. The title is therefore partially related: it refers to real aspects of the change but is broad and does not state the main point.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.
⚠️ Outside diff range comments (1)
Minor · Use a width fallback for CustomTkinter 5.2.x. · ui.py:1035
Buildscripts/TactilitySDK/Tools/ui.py:1035 Minor · Stability & Availability · Quick win
Use a width fallback for CustomTkinter 5.2.x.
CustomTkinter 5.2.2 CTkProgressBar has no length parameter. It forwards unknown keyword arguments to the base widget, which raises TclError. When CustomTkinter 5.2.x is installed, length=180 stops DevConsole initialization.
The Custom2kinter documentation lists length, so the Custom2kinter path is not affected. Use a fallback that tries length first and then width:
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keyboard capabilities
KeyboardApinow hasuint32_t capabilitiesas its first member.KEYBOARD_CAPABILITY_RESTRICTEDmarks limited keyboards.is_presentwas dropped.keyboard_has_capability..capabilities.Kernel display hook
struct DisplayHookwithon_*callbacks anddisplay_set_hook().symbols.cand covered bydisplay_hook_test.cpp.Remote access (
Modules/development-module)Viewer (
Buildscripts/TactilitySDK/Tools)remote.pyand_remote_viewer.pyuse Custom2kinter.Summary by CodeRabbit
tt remotecommand, with live display updates, screenshots, rotation and zoom controls, and keyboard and touch input.